chore: Clean up parser comments
#15252
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53653/ |
| leadingNode: Node | null; | ||
| trailingNode: Node | null; | ||
| containingNode: Node | null; | ||
| start: number; // the start of the whitespace token. |
There was a problem hiding this comment.
Nit, but if we use jsdoc-like comments editors will show the as the description in autocompletion:
/**
* The start of the whitespace token.
*/
start: number;even if probably comments for start/end/comments are not needed.
There was a problem hiding this comment.
I tried that but it doesn't seem to work.😕
There was a problem hiding this comment.
It should work when overing over start:
| * ↓↓↓ We had escaped "\/" to "\\/" for comments | ||
| * For example, when parsing *\/ | ||
| * // async /* 1 *\/ function f() {} |
There was a problem hiding this comment.
I actually prefer the old comment style, so that it didn't need escapes 😛
There was a problem hiding this comment.
I also hate escaping, but the old ones are.😭
There was a problem hiding this comment.
Can you try if JLHwung@6eee6d0 works? I added U+200B between * and /.
There was a problem hiding this comment.
Wow this is awesome, thank you!
liuxingbaoyu
force-pushed
the
clean-comments
branch
from
ed42bf1
to
4006119
Compare
github-actions
bot
added
the
outdated
Fixes #1, Fixes #2